Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decentralized pallet-staking audit tool #1854

Closed
wants to merge 2 commits into from
Closed

Decentralized pallet-staking audit tool #1854

wants to merge 2 commits into from

Conversation

taqtiqa-mark
Copy link
Contributor

Project Abstract

Grant level

  • Level 2: Up to $30,000, 3 approvals

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).

Noc2
Noc2 requested changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. In general, we are interested in a better overview when it comes to staking (and slashing) and also in regard to historical data. So you can add more details to the milestones and make this application more than a draft. I have one initial question: What do you mean by workbook? Do you plan to create a shared Google sheet or something similar?

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Jul 19, 2023
@Noc2 Noc2 mentioned this pull request Jul 19, 2023
Closed
7 tasks
@taqtiqa-mark
Copy link
Contributor Author

taqtiqa-mark commented Jul 19, 2023 •
edited
Loading

I have one initial question: What do you mean by workbook? Do you plan to create a shared Google sheet or something similar?

The intention is to have a decentralized tool, apart from trying to escape the surveillance business models. So, I'll make sure to provide an OpenOffice/LibreOffice Calc workbook. The idea is that a relay chain that uses pallet-staking distributes it as part of its toolchain.

I'll add the milestone details.

@taqtiqa-mark taqtiqa-mark requested a review from Noc2 July 23, 2023 08:00
Noc2
Noc2 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed the level: c0ac446 Otherwise, it looks good to me, and I'm happy to go ahead with it.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Jul 24, 2023
@takahser
Copy link
Collaborator

@taqtiqa-mark just a question here - are you planning to complete your active grant before potentially starting this one (given, it'll get accepted)? I'm asking because usually we ask grantees to finish any active grant before starting a new one. That being said, I saw your note that this proposal is still considered to be a draft, so if you're just looking for feedback on this while finishing your previous grant, I'm fine with the approach.

@taqtiqa-mark
Copy link
Contributor Author

@taqtiqa-mark just a question here - are you planning to complete your active grant before potentially starting this one

Yes. I believe that grant is effectively complete, subject to reviewer feedback.

@takahser
Copy link
Collaborator

@taqtiqa-mark thanks for pointing out, there seems to have been an issue with syncing this delivery in our internal process. I'm going to take a look at it soon.

@takahser takahser self-requested a review July 25, 2023 12:09
@taqtiqa-mark
Copy link
Contributor Author

taqtiqa-mark commented Jul 25, 2023 •
edited
Loading

so if you're just looking for feedback on this while finishing your previous grant, I'm fine with the approach.

FYI, @Noc2 has advised that only one application is considered at a time. I've indicated that in my view application #1848 is the higher priority.

dsm-w3f
dsm-w3f reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@dsm-w3f dsm-w3f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taqtiqa-mark thank you for the application. Could you provide more details on how do you plan to integrate the workbook with the pallets? Furthermore, how do plan to assure the quality of the software developed? Can you provide an overview of your experience with software development?

@taqtiqa-mark
Copy link
Contributor Author

@taqtiqa-mark thank you for the application.

FYI, @Noc2 has advised that only one application is considered at a time. I've indicated that in my view application #1848 is the higher priority. If that application is rejected I'll update with the details requested.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Jul 31, 2023

@taqtiqa-mark I reviewed this one and not the other since this is the only one marked as ready to review. The other application still needs some clarification to go for committee review. I'll comment there about it.

@takahser takahser self-assigned this Aug 2, 2023
@semuelle semuelle added the on hold There is an external blocker, such as another grant in progress. label Aug 11, 2023
@taqtiqa-mark
Copy link
Contributor Author

In light of the experience with the grant Token economics survey (2022). Specifically, the attempt, on the brink of accepting Milestone 3, to bring within scope material that was clearly defined as out of scope, and the attempt to have guidance provided to block chain teams. Details here:

taqtiqa-mark/tokenomics-survey-2022#4

And given the complexity and subtlety of the analysis that is the subject of this application, prior experience dictates it is prudent to:

  1. Suspend this application
  2. Revise the application to reflect the risks noted above

I'll reopen in due course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsm-w3f dsm-w3f dsm-w3f left review comments

@Noc2 Noc2 Noc2 approved these changes

@takahser takahser Awaiting requested review from takahser

Assignees

@takahser takahser

Labels
on hold There is an external blocker, such as another grant in progress. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taqtiqa-mark @takahser @dsm-w3f @Noc2 @semuelle